madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib issue #292: Internal: Add function to check column type for 1D array
Date Thu, 12 Jul 2018 20:52:43 GMT
Github user iyerr3 commented on the issue:

    https://github.com/apache/madlib/pull/292
  
    Few comments: 
    1. The query would read better if it is setup to return a boolean i.e. using `array_upper(...,
2) IS NULL` instead of converting the integer output to bool in Python. 
    2. My request in #291 for moving this to a separate commit was for the `plpy_mock.py_in`
file since that looks like an independent work. This function is minor enough that it can
be kept in #291. 
    3. The unit test for this function isn't really testing anything except the last line
in the function. That also becomes moot if comment 1. is accepted. Considering this, I suggest
we don't have the unit test for this function (at least not in the form it currently is).



---

Mime
View raw message