madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #291: Feature: Vector to Columns
Date Thu, 12 Jul 2018 00:25:19 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/291#discussion_r201877031
  
    --- Diff: src/ports/postgres/modules/utilities/test/unit_tests/test_utilities.py_in ---
    @@ -243,6 +243,9 @@ class UtilitiesTestCase(unittest.TestCase):
             self.assertFalse(s.is_valid_psql_type('boolean[]', s.INCLUDE_ARRAY | s.ONLY_ARRAY))
             self.assertFalse(s.is_valid_psql_type('boolean', s.ONLY_ARRAY))
             self.assertFalse(s.is_valid_psql_type('boolean[]', s.ONLY_ARRAY))
    +        self.assertTrue(s.is_valid_psql_type('boolean[]', s.ANY_ARRAY))
    --- End diff --
    
    Can we move this and corresponding code changes to another commit and PR? 


---

Mime
View raw message