madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #286: Build: Remove symlinks during rpm uninstall
Date Tue, 10 Jul 2018 21:30:43 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/286#discussion_r201501717
  
    --- Diff: pom.xml ---
    @@ -66,6 +66,7 @@
                   <exclude>deploy/preflight.sh</exclude>
                   <exclude>deploy/RPM/CMakeLists.txt</exclude>
                   <exclude>deploy/rpm_post.sh</exclude>
    +              <exclude>deploy/rpm_post_uninstall.sh</exclude>
    --- End diff --
    
    This was done under the assumption that Apache does not need the license header for simple
scripts that don't have considerable IP. In this case, we're only removing some files and
a directory, so assuming that it's fine to not explicitly tag the license. Let me know if
you feel otherwise. 


---

Mime
View raw message