madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #289: RF: Add impurity variable importance
Date Tue, 10 Jul 2018 21:23:43 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/289#discussion_r201490136
  
    --- Diff: src/modules/recursive_partitioning/decision_tree.cpp ---
    @@ -502,10 +502,13 @@ get_variable_importance::run(AnyType &args){
        ColumnVector combined_var_imp(n_cat_features + n_con_features);
        combined_var_imp << cat_var_importance, con_var_importance;
     
    -    // Avoid divide by zero by adding a small number.
    +    // Avoid divide by zero by replacing with a small number if necessary
    --- End diff --
    
    Out of curiosity: what was wrong with the previous method? 


---

Mime
View raw message