From dev-return-3397-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Fri Jun 15 20:38:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CE346180636 for ; Fri, 15 Jun 2018 20:38:51 +0200 (CEST) Received: (qmail 54752 invoked by uid 500); 15 Jun 2018 18:38:50 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 54737 invoked by uid 99); 15 Jun 2018 18:38:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 18:38:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 043D0E110D; Fri, 15 Jun 2018 18:38:50 +0000 (UTC) From: njayaram2 To: dev@madlib.apache.org Reply-To: dev@madlib.apache.org References: In-Reply-To: Subject: [GitHub] madlib pull request #276: Feature/dev check Content-Type: text/plain Message-Id: <20180615183850.043D0E110D@git1-us-west.apache.org> Date: Fri, 15 Jun 2018 18:38:50 +0000 (UTC) Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/276#discussion_r195830080 --- Diff: src/madpack/madpack.py --- @@ -898,13 +900,19 @@ def run_install_check(args, testcase): % (test_user, test_schema, schema) # Loop through all test SQL files for this module - sql_files = maddir_mod_sql + '/' + module + '/test/*.sql_in' + if is_install_check: + sql_files = maddir_mod_sql + '/' + module + '/test/*.ic.sql_in' + else: + sql_files = maddir_mod_sql + '/' + module + '/test/*.sql_in' for sqlfile in sorted(glob.glob(sql_files), reverse=True): algoname = os.path.basename(sqlfile).split('.')[0] # run only algo specified if (module in modset and modset[module] and algoname not in modset[module]): continue + # Do not run test/*.ic.sql_in files for dev-check. --- End diff -- That's great, will try it out. ---