madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaknikhil <...@git.apache.org>
Subject [GitHub] madlib pull request #279: KNN: make install check asserts deterministic
Date Fri, 15 Jun 2018 00:58:02 GMT
GitHub user kaknikhil opened a pull request:

    https://github.com/apache/madlib/pull/279

    KNN: make install check asserts deterministic

    knn install check had a couple of array_agg asserts which were not
    deterministic. This commit adds order by to the array agg function to
    make it deterministic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/knn_ic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit c117afa614bb84c4cc36b466934247e51d2eff4e
Author: Nikhil Kak <nkak@...>
Date:   2018-06-14T17:20:55Z

    KNN: make install check asserts deterministic
    
    knn install check had a couple of array_agg asserts which were not
    deterministic. This commit adds order by to the array agg function to
    make it derterministic.

----


---

Mime
View raw message