madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] madlib pull request #275: Madpack: Fix error with dropping user after IC fai...
Date Tue, 05 Jun 2018 20:50:45 GMT
GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/275

    Madpack: Fix error with dropping user after IC failure.

    JIRA: MADLIB-1182
    
    Previously, when install check did not fail gracefully, the user created
    by madpack hung around and disturbed IC attempts within other databases.
    We fixed this by:
    1) Renaming the test user using the specific database that the IC test
    was run from, making the test user name database-specific.
    2) Dropping schema and user in a try-finally block, so that it's executed even
    on a failed IC run.
    
    Co-authored-by: Arvind Sridhar <asridhar@pivotal.io>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/madpack-ic-user

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #275
    
----
commit d817973e78fa419dd7b83b077049c8c6b1911911
Author: Nandish Jayaram <njayaram@...>
Date:   2018-06-05T19:08:25Z

    Madpack: Fix error with dropping user after IC failure.
    
    JIRA: MADLIB-1182
    
    Previously, when install check did not fail gracefully, the user created
    by madpack hung around and disturbed IC attempts within other databases.
    We fixed this by:
    1) Renaming the test user using the specific database that the IC test
    was run from, making the test user name database-specific.
    2) Dropping schema and user in a try-finally block, so that it's executed even
    on a failed IC run.
    
    Co-authored-by: Arvind Sridhar <asridhar@pivotal.io>

----


---

Mime
View raw message