madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kaknikhil <...@git.apache.org>
Subject [GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns
Date Thu, 28 Jun 2018 23:48:43 GMT
Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/282#discussion_r199002193
  
    --- Diff: src/ports/postgres/modules/utilities/test/utilities.ic.sql_in ---
    @@ -0,0 +1,58 @@
    +/* ----------------------------------------------------------------------- */
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + *
    + *//* ----------------------------------------------------------------------- */
    +
    +-- cleanup
    +SELECT cleanup_madlib_temp_tables(quote_ident(current_schema()));
    --- End diff --
    
    I am assuming that we moved this test from the `drop_madlib_temp.ic.sql_in` file to this
generic utilities install check test, right ?


---

Mime
View raw message