madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] madlib pull request #276: Feature/dev check
Date Fri, 15 Jun 2018 18:38:50 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/276#discussion_r195830080
  
    --- Diff: src/madpack/madpack.py ---
    @@ -898,13 +900,19 @@ def run_install_check(args, testcase):
                       % (test_user, test_schema, schema)
     
             # Loop through all test SQL files for this module
    -        sql_files = maddir_mod_sql + '/' + module + '/test/*.sql_in'
    +        if is_install_check:
    +            sql_files = maddir_mod_sql + '/' + module + '/test/*.ic.sql_in'
    +        else:
    +            sql_files = maddir_mod_sql + '/' + module + '/test/*.sql_in'
             for sqlfile in sorted(glob.glob(sql_files), reverse=True):
                 algoname = os.path.basename(sqlfile).split('.')[0]
                 # run only algo specified
                 if (module in modset and modset[module] and
                         algoname not in modset[module]):
                     continue
    +            # Do not run test/*.ic.sql_in files for dev-check.
    --- End diff --
    
    That's great, will try it out.


---

Mime
View raw message