From dev-return-2813-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Thu Feb 15 17:11:49 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6326C18064A for ; Thu, 15 Feb 2018 17:11:49 +0100 (CET) Received: (qmail 75195 invoked by uid 500); 15 Feb 2018 16:11:48 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 75183 invoked by uid 99); 15 Feb 2018 16:11:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Feb 2018 16:11:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A5E97E0904; Thu, 15 Feb 2018 16:11:47 +0000 (UTC) From: iyerr3 To: dev@madlib.apache.org Reply-To: dev@madlib.apache.org Message-ID: Subject: [GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl... Content-Type: text/plain Date: Thu, 15 Feb 2018 16:11:47 +0000 (UTC) GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/236 DT: Ensure n_folds and null_proxy are set correctly The summary table in Decision Tree included two entries: k and null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but was not set correctly and was always NULL. The null_proxy was supposed to be NULL when null_as_category=False but was set to the string 'NULL'. Both these issues have been corrected in this commit. Closes #236 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iyerr3/incubator-madlib bugfix/dt_incorrect_output_values Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #236 ---- commit 4d27ba64c322c1e0f5423cebb805738aa84f5dcb Author: Rahul Iyer Date: 2018-02-15T16:07:49Z DT: Ensure n_folds and null_proxy are set correctly The summary table in Decision Tree included two entries: k and null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but was not set correctly and was always NULL. The null_proxy was supposed to be NULL when null_as_category=False but was set to the string 'NULL'. Both these issues have been corrected in this commit. Closes #236 ---- ---