From dev-return-2819-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Thu Feb 15 19:42:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00C6B18064A for ; Thu, 15 Feb 2018 19:42:31 +0100 (CET) Received: (qmail 50598 invoked by uid 500); 15 Feb 2018 18:42:31 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 50578 invoked by uid 99); 15 Feb 2018 18:42:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Feb 2018 18:42:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4DEABE0904; Thu, 15 Feb 2018 18:42:30 +0000 (UTC) From: njayaram2 To: dev@madlib.apache.org Reply-To: dev@madlib.apache.org References: In-Reply-To: Subject: [GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl... Content-Type: text/plain Message-Id: <20180215184230.4DEABE0904@git1-us-west.apache.org> Date: Thu, 15 Feb 2018 18:42:30 +0000 (UTC) Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/236#discussion_r168569487 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in --- @@ -1463,15 +1463,15 @@ def _create_summary_table( cp_str = py_list_to_sql_string(cp, 'double precision') else: cp_str = str(cp) + "::double precision" - fold = k if running_cv else "NULL" + # n_folds_str = n_folds if running_cv else "NULL" --- End diff -- Can we remove this commented line? ---