GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/236
DT: Ensure n_folds and null_proxy are set correctly
The summary table in Decision Tree included two entries: k and
null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but
was not set correctly and was always NULL. The null_proxy was supposed
to be NULL when null_as_category=False but was set to the string 'NULL'.
Both these issues have been corrected in this commit.
Closes #236
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyerr3/incubator-madlib bugfix/dt_incorrect_output_values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #236
----
commit 4d27ba64c322c1e0f5423cebb805738aa84f5dcb
Author: Rahul Iyer <riyer@...>
Date: 2018-02-15T16:07:49Z
DT: Ensure n_folds and null_proxy are set correctly
The summary table in Decision Tree included two entries: k and
null_proxy. The 'k' value is supposed to reflect the 'n_folds' value but
was not set correctly and was always NULL. The null_proxy was supposed
to be NULL when null_as_category=False but was set to the string 'NULL'.
Both these issues have been corrected in this commit.
Closes #236
----
---
|