Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/237#discussion_r169845958
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -749,8 +749,18 @@ def mlp_predict(schema_madlib,
summary['layer_sizes'], array_type="DOUBLE PRECISION")
is_classification = int(summary["is_classification"])
is_response = int(pred_type == 'response')
- grouping_col = '' if summary['grouping_col']=='NULL' \
- else summary['grouping_col']
+ if 'grouping_col' in summary:
+ # This model was created in MADlib 1.13 or greater version
+ is_v112_model = False
--- End diff --
I prefer calling the flag `is_pre_113_model` as that makes the intention clearer.
---
|