madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] madlib pull request #236: DT: Ensure n_folds and null_proxy are set correctl...
Date Thu, 15 Feb 2018 18:42:30 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/236#discussion_r168569487
  
    --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in ---
    @@ -1463,15 +1463,15 @@ def _create_summary_table(
             cp_str = py_list_to_sql_string(cp, 'double precision')
         else:
             cp_str = str(cp) + "::double precision"
    -    fold = k if running_cv else "NULL"
    +    # n_folds_str = n_folds if running_cv else "NULL"
    --- End diff --
    
    Can we remove this commented line?


---

Mime
View raw message