madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #232: Multiple LDA improvements and fixes
Date Thu, 15 Feb 2018 16:37:09 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/232#discussion_r168526426
  
    --- Diff: src/ports/postgres/modules/lda/lda.py_in ---
    @@ -120,14 +120,22 @@ class LDATrainer:
             # etime = time.time()
             # plpy.notice('\t\ttime elapsed: %.2f seconds' % (etime - stime))
     
    -    def gen_output_data_table(self):
    +    def gen_final_data_tables(self):
             # stime = time.time()
             # plpy.notice('\t\tgenerating output data table ...')
     
    -        work_table_final = self.work_table_1
    -        if self.iter_num % 2 == 0:
    -            work_table_final = self.work_table_0
    +        ##This function updates 2 tables, one is the model table and
    +        # the other one is the output table
     
    +        work_table_final = self.work_table_0 if self.iter_num % 2 == 0 \
    +        else self.work_table_1
    +
    +        # Update model table
    +        #JIRA:MADLIB-1201, we have to update model table one more time after
    --- End diff --
    
    I suggest not adding the JIRA number here, because it doesn't add more context. 


---

Mime
View raw message