madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #235: update KNN, DT and RF docs to match recent commits
Date Thu, 15 Feb 2018 16:10:48 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/235#discussion_r168523757
  
    --- Diff: src/ports/postgres/modules/recursive_partitioning/random_forest.sql_in ---
    @@ -208,13 +208,26 @@ forest_train(training_table_name,
     
         <tr>
         <th>dependent_var_levels</th>
    -    <td>itext. For classification, the distinct levels of the dependent variable.</td>
    +    <td>text. For classification, the distinct levels of the dependent variable.</td>
         </tr>
     
         <tr>
         <th>dependent_var_type</th>
         <td>text. The type of dependent variable.</td>
         </tr>
    +
    +    <tr>
    +    <th>independent_var_types</th>
    +    <td>text. A comma separated string for the types of independent variables.</td>
    +    </tr>
    +
    +    <tr>
    +    <th>null_proxy</th>
    +    <td>text. Describes how NULLs are handled.  If NULL is not 
    +    treated as a separate categorical variable, this will be blank.
    --- End diff --
    
    again `this will be NULL` is more appropriate. 


---

Mime
View raw message