madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #235: update KNN, DT and RF docs to match recent commits
Date Thu, 15 Feb 2018 16:10:47 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/235#discussion_r168523662
  
    --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in ---
    @@ -355,6 +355,19 @@ tree_train(
         <th>independent_var_types</th>
         <td>TEXT. A comma separated string for the types of independent variables.</td>
         </tr>
    +
    +    <tr>
    +    <th>n_folds</th>
    +    <td>BIGINT. Number of cross-validation folds used.</td>
    +    </tr>
    +
    +    <tr>
    +    <th>null_proxy</th>
    +    <td>TEXT. Describes how NULLs are handled.  If NULL is not 
    +    treated as a separate categorical variable, this will be blank.
    --- End diff --
    
    I suggest replacing `this will be blank` with `this will be NULL`. The `blank` for NULL
is the default in psql but that can easily be changed. 


---

Mime
View raw message