madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From orhankislal <...@git.apache.org>
Subject [GitHub] madlib pull request #224: 1.13 Upgrade and MLP IC fix
Date Fri, 12 Jan 2018 01:25:33 GMT
GitHub user orhankislal opened a pull request:

    https://github.com/apache/madlib/pull/224

    1.13 Upgrade and MLP IC fix

    JIRA: MADLIB-1197
    
    Additional Author: Nandish Jayaram <njayaram@apache.org>
    
    - 1.13 Upgrade does not drop the kNN help functions even though their
    return types are changed. This commit adds the missing functions to the
    changelist and alters the upgrade_util.py_in so that functions without
    arguments can be dropped.
    
    - Some assert thresholds are too strict for MLP in IC. This commit relaxes
    those thresholds.
    
    Closes #224

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/orhankislal/madlib bugfix/mlp_and_upgrade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit 0fdf136b4e0ad0fd2c54bab2144045b11ba5884b
Author: Orhan Kislal <okislal@...>
Date:   2018-01-12T01:22:30Z

    1.13 Upgrade and MLP IC fix
    
    JIRA: MADLIB-1197
    
    Additional Author: Nandish Jayaram <njayaram@apache.org>
    
    - 1.13 Upgrade does not drop the kNN help functions even though their
    return types are changed. This commit adds the missing functions to the
    changelist and alters the upgrade_util.py_in so that functions without
    arguments can be dropped.
    
    - Some assert thresholds are too strict for MLP in IC. This commit relaxes
    those thresholds.
    
    Closes #224

----


---

Mime
View raw message