madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From orhankislal <...@git.apache.org>
Subject [GitHub] madlib pull request #229: SVM: Add minibatch as a new solver
Date Wed, 24 Jan 2018 21:59:22 GMT
Github user orhankislal commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/229#discussion_r163689232
  
    --- Diff: src/ports/postgres/modules/svm/svm.py_in ---
    @@ -89,9 +113,9 @@ def _verify_table(source_table, model_table, dependent_varname,
                     "('{dependent_varname}') for source_table "
                     "({source_table})!".format(dependent_varname=dependent_varname,
                                                source_table=source_table))
    -        dep_type = get_expr_type(dependent_varname, source_table)
    -        if '[]' in dep_type:
    -            plpy.error("SVM error: dependent_varname cannot be of array type!")
    +        # dep_type = get_expr_type(dependent_varname, source_table)
    --- End diff --
    
    We should remove these lines if we don't need them.


---

Mime
View raw message