madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #229: SVM: Add minibatch as a new solver
Date Mon, 22 Jan 2018 18:19:04 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/229#discussion_r163022926
  
    --- Diff: src/modules/convex/algo/igd.hpp ---
    @@ -34,7 +34,10 @@ class IGD {
         typedef typename Task::model_type model_type;
     
         static void transition(state_type &state, const tuple_type &tuple);
    +    static void transitionInMiniBatch(state_type &state, const tuple_type &tuple);
    +    static void transitionInMiniBatch2(state_type &state, const tuple_type &tuple);
    --- End diff --
    
    We don't - I'll delete that. 


---

Mime
View raw message