Return-Path: <dev-return-2433-archive-asf-public=cust-asf.ponee.io@madlib.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7A9EF200D4C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 15 Nov 2017 09:55:51 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 78F57160BEA; Wed, 15 Nov 2017 08:55:51 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BD705160BF6
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 15 Nov 2017 09:55:50 +0100 (CET)
Received: (qmail 6273 invoked by uid 500); 15 Nov 2017 08:55:49 -0000
Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@madlib.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@madlib.apache.org>
List-Post: <mailto:dev@madlib.apache.org>
List-Id: <dev.madlib.apache.org>
Reply-To: dev@madlib.apache.org
Delivered-To: mailing list dev@madlib.apache.org
Received: (qmail 6133 invoked by uid 99); 15 Nov 2017 08:55:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Nov 2017 08:55:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 8D296F2DCA; Wed, 15 Nov 2017 08:55:47 +0000 (UTC)
From: jingyimei <git@git.apache.org>
To: dev@madlib.apache.org
Reply-To: dev@madlib.apache.org
References: <git-pr-195-madlib@git.apache.org>
In-Reply-To: <git-pr-195-madlib@git.apache.org>
Subject: [GitHub] madlib pull request #195: Feature: Add grouping support to HITS 
Content-Type: text/plain
Message-Id: <20171115085548.8D296F2DCA@git1-us-west.apache.org>
Date: Wed, 15 Nov 2017 08:55:47 +0000 (UTC)
archived-at: Wed, 15 Nov 2017 08:55:51 -0000

Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/195#discussion_r151062713
  
    --- Diff: src/ports/postgres/modules/graph/hits.sql_in ---
    @@ -164,10 +168,20 @@ INSERT INTO edge VALUES
     (3, 0, 1),
     (4, 0, 1),
     (5, 6, 1),
    -(6, 3, 1);
    +(6, 3, 1),
    +(0, 1, 2),
    +(0, 2, 2),
    +(0, 4, 2),
    +(1, 2, 2),
    +(1, 3, 2),
    +(2, 3, 2),
    +(3, 0, 2),
    +(4, 0, 2),
    +(5, 6, 2),
    +(6, 3, 2);
     </pre>
     
    --# Compute the HITS scores:
    +-# Running HITS with default values for optional parameters:
    --- End diff --
    
    In those examples without grouping, duplicate edges from different groups are calculated twice. We discussed this before and just wondering if we can add some explanation here(may not be necessary tho).


---