madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] madlib pull request #195: Feature: Add grouping support to HITS
Date Mon, 13 Nov 2017 19:20:52 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/195#discussion_r150638553
  
    --- Diff: src/ports/postgres/modules/utilities/validate_args.py_in ---
    @@ -262,6 +262,13 @@ def get_first_schema(table_name):
         return None
     # -------------------------------------------------------------------------
     
    +def drop_tables(table_list):
    +    """
    +        Drop tables specified in table_list.
    +    """
    +    drop_str = ', '.join([table for table in table_list])
    --- End diff --
    
    Why not just `', '.join(table_list)`?


---

Mime
View raw message