Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@madlib.incubator.apache.org
From: iyerr3 <git@git.apache.org>
To: dev@madlib.incubator.apache.org
Reply-To: dev@madlib.incubator.apache.org
References: <git-pr-123-incubator-madlib@git.apache.org>
In-Reply-To: <git-pr-123-incubator-madlib@git.apache.org>
Subject: [GitHub] incubator-madlib pull request #123: MADLIB-1076. Review LICENSE file and REA...
Content-Type: text/plain
Message-Id: <20170420195019.88361F49FF@git1-us-west.apache.org>
Date: Thu, 20 Apr 2017 19:50:19 +0000 (UTC)
archived-at: Thu, 20 Apr 2017 19:50:26 -0000

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/123#discussion_r112544703
  
    --- Diff: src/CMakeLists.txt ---
    @@ -18,10 +18,10 @@ set(BITBUCKET_BASE_URL
         "${MADLIB_REDIRECT_PREFIX}https://bitbucket.org"
         CACHE STRING
         "Base URL for Bitbucket projects. May be overridden for testing purposes.")
    -set(GITHUB_MADLIB_BASE_URL
    +set(EIGEN_BASE_URL
    --- End diff --
    
    Since this is Eigen specific link, please include the `eigen/archive` part from line 55 in the URL itself.  That way it's used specifically for that purpose. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---