Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BC9A6200C5A for ; Tue, 18 Apr 2017 21:08:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BB316160BA1; Tue, 18 Apr 2017 19:08:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0EDE5160B87 for ; Tue, 18 Apr 2017 21:08:57 +0200 (CEST) Received: (qmail 21676 invoked by uid 500); 18 Apr 2017 19:08:57 -0000 Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.incubator.apache.org Delivered-To: mailing list dev@madlib.incubator.apache.org Received: (qmail 21664 invoked by uid 99); 18 Apr 2017 19:08:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 19:08:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A74F5C0F8E for ; Tue, 18 Apr 2017 19:08:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pw8Gii6A_eOv for ; Tue, 18 Apr 2017 19:08:54 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 793785FB29 for ; Tue, 18 Apr 2017 19:08:53 +0000 (UTC) Received: (qmail 21639 invoked by uid 99); 18 Apr 2017 19:08:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2017 19:08:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 92F19DFB92; Tue, 18 Apr 2017 19:08:52 +0000 (UTC) From: iyerr3 To: dev@madlib.incubator.apache.org Reply-To: dev@madlib.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-madlib issue #117: Decision Tree: Update defaults for max_depth, n... Content-Type: text/plain Message-Id: <20170418190852.92F19DFB92@git1-us-west.apache.org> Date: Tue, 18 Apr 2017 19:08:52 +0000 (UTC) archived-at: Tue, 18 Apr 2017 19:08:58 -0000 Github user iyerr3 commented on the issue: https://github.com/apache/incubator-madlib/pull/117 No, that's a separate JIRA: MADLIB-1057 . This one is just about setting the defaults to a more reasonable value considering the data that users have shared. The commit is a little more than just changing two numbers since I updated the way these defaults are set. Previously they were set in overloaded function declaration (in SQL). Changed this to set the default in the main function definition, eliminating redundancy. Thanks, Rahul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---