madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #125: DT: Include rows with NULL features in t...
Date Wed, 26 Apr 2017 22:48:16 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/125#discussion_r113580770
  
    --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in ---
    @@ -1582,38 +1578,17 @@ def _create_summary_table(
     # ------------------------------------------------------------
     
     
    -def _get_filter_str(schema_madlib, cat_features, con_features,
    -                    boolean_cats, dependent_variable,
    -                    grouping_cols, max_n_surr=0):
    +def _get_filter_str(dependent_variable, grouping_cols):
    --- End diff --
    
    I think this function is still called with 7 arguments in the random forest module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message