madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #119: Multiple: Minor changes for GPDB5 and HA...
Date Thu, 20 Apr 2017 19:04:19 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/119#discussion_r112535164
  
    --- Diff: src/ports/postgres/modules/graph/sssp.py_in ---
    @@ -432,11 +433,17 @@ def graph_sssp(schema_madlib, vertex_table, vertex_id, edge_table,
     								SELECT 1
     								FROM {oldupdate} as oldupdate
     								WHERE {checkg_oo_sub}
    -								);
    -						DROP TABLE {out_table};
    -						ALTER TABLE {temp_table} RENAME TO {out_table};"""
    -
    -				plpy.execute(sql_del.format(**locals()))
    +								);"""
    +					plpy.execute(sql_del.format(**locals()))
    +					sql_del = "DROP TABLE {out_table}"
    +					plpy.execute(sql_del.format(**locals()))
    +					sql_del = "ALTER TABLE {temp_table} RENAME TO {out_table};"
    +					plpy.execute(sql_del.format(**locals()))
    --- End diff --
    
    Same as previous comment - all these `plpy.execute` can directly run the string, simplifying
the code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message