madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] incubator-madlib issue #70: Build: Fix version parsing in madpack
Date Mon, 31 Oct 2016 18:55:16 GMT
Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/70
  
    Thanks! Updated code.
    
    On Sun, Oct 30, 2016 at 9:39 AM, Stephen Carter <notifications@github.com>
    wrote:
    
    > There is another line where we need to convert back to str for
    > concatenation:
    >
    > https://github.com/iyerr3/incubator-madlib/blob/0e5aa9f330c706a3d1e715879bbfd792953f1834/src/madpack/madpack.py#L518
    > temp_schema = schema + '_v' + ''.join(str(_get_rev_num(dbrev)))
    >
    > In testing this gives me:
    >
    > >>> ver = [4,3,10]
    > >>> 'test' + ''.join(str(ver))
    > 'test[4, 3, 10]'
    >
    > I think the line should be:
    >
    > >>> 'test' + ''.join(map(str, ver))
    > 'test4310'
    >
    > And following should use _is_rev_gte:
    >
    > https://github.com/iyerr3/incubator-madlib/blob/0e5aa9f330c706a3d1e715879bbfd792953f1834/src/madpack/madpack.py#L323
    > if _get_rev_num(match_details.group(1)) >= _get_rev_num('4.3.5'):
    >
    > Other than that I have not seen any other locations that call _get_rev_num
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-madlib/pull/70#issuecomment-257161952>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ACIkB8oFuVQOI_ogbi02z4Cfh89YQMmmks5q5MgrgaJpZM4KZAPH>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message