madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stephendotcarter <...@git.apache.org>
Subject [GitHub] incubator-madlib issue #70: Build: Fix version parsing in madpack
Date Sun, 30 Oct 2016 12:38:57 GMT
Github user stephendotcarter commented on the issue:

    https://github.com/apache/incubator-madlib/pull/70
  
    Returning elements as str does not work when comparing different versions on line and
is causing the install to fail on Greenplum 4.3.10:
    
    ```
    if _get_rev_num(match_details.group(1)) >= _get_rev_num('4.3.5'):
        return '4.3ORCA'
    ```
    
    This evaluates as:
    ```
    >>> ['4','3','10'] > ['4','3','5']
    False
    ```
    
    They need to be int for the comparison to work:
    ```
    >>> [4,3,10] > [4,3,5]
    True
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message