madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <>
Subject [GitHub] incubator-madlib pull request #70: Build: Fix version parsing in madpack
Date Mon, 17 Oct 2016 19:35:46 GMT
Github user iyerr3 commented on a diff in the pull request:
    --- Diff: src/madpack/ ---
    @@ -357,7 +356,7 @@ def _get_rev_num(rev):
             @param rev version text
    -        num = re.findall('[0-9]', rev)
    --- End diff --
    The primary bug in `re.findall('[0-9]', rev)` was that a version string like `1.3.10`
resulted in output `[1, 3, 1, 0]` instead of `[1, 3, 10]`. This PR solely aims to fix that.
Ideally I would like to use something like `distutils.version.LooseVersion` to compare versions,
but we also need the version parsed in a list and I'm not aware if `LooseVersion` provides

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message