Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0B6B8200B50 for ; Sat, 30 Jul 2016 00:54:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 09F3F160AA6; Fri, 29 Jul 2016 22:54:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 51007160A79 for ; Sat, 30 Jul 2016 00:54:49 +0200 (CEST) Received: (qmail 37430 invoked by uid 500); 29 Jul 2016 22:54:48 -0000 Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.incubator.apache.org Delivered-To: mailing list dev@madlib.incubator.apache.org Received: (qmail 37419 invoked by uid 99); 29 Jul 2016 22:54:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2016 22:54:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E5096C121D for ; Fri, 29 Jul 2016 22:54:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.307 X-Spam-Level: X-Spam-Status: No, score=-5.307 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5236XTLV0OFr for ; Fri, 29 Jul 2016 22:54:44 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id E1CA05F19B for ; Fri, 29 Jul 2016 22:54:41 +0000 (UTC) Received: (qmail 37345 invoked by uid 99); 29 Jul 2016 22:54:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2016 22:54:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D2680EC22C; Fri, 29 Jul 2016 22:54:40 +0000 (UTC) From: iyerr3 To: dev@madlib.incubator.apache.org Reply-To: dev@madlib.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-madlib issue #54: Pivoting: Phase 2 Content-Type: text/plain Message-Id: <20160729225440.D2680EC22C@git1-us-west.apache.org> Date: Fri, 29 Jul 2016 22:54:40 +0000 (UTC) archived-at: Fri, 29 Jul 2016 22:54:50 -0000 Github user iyerr3 commented on the issue: https://github.com/apache/incubator-madlib/pull/54 Even for the other two, I suggest keeping the static parts all together with only the dynamic part created in the loops. That avoids having the `SELECT` clause separated from the `FROM` by 70 lines. That avoids creating a variable `insert_sql_begin` 50+ lines from where it's used (and can be replaced by static string `INSERT INTO`). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---