madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #58: Sessionize function: Handling NULL for pa...
Date Wed, 27 Jul 2016 20:37:48 GMT
GitHub user njayaram2 opened a pull request:

    https://github.com/apache/incubator-madlib/pull/58

    Sessionize function: Handling NULL for partition_expr

    JIRA: MADLIB-1001
    
    Changes here now set partition_expr to partition across the whole table
    if it is originally set to NULL or '' by the user. This is in line with
    how path handles partition_expr. Additionally, if output_expr has NULL
    or '' as its value, it is set to '*', which is its default value. Finally,
    the create_view param is also set to its default value True if NULL.
    This commit also contains some formatting changes to the online help.
    
    @iyerr3 @fmcquillan99 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/njayaram2/incubator-madlib bugfix/sessionize-feature-comments

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 17457ea850e0cf8a2cf4100a754c944f7e622c35
Author: Nandish Jayaram <njayaram@pivotal.io>
Date:   2016-07-27T20:27:50Z

    Sessionize function: Handling NULL for partition_expr
    
    JIRA: MADLIB-1001
    
    Changes here now set partition_expr to partition across the whole table
    if it is originally set to NULL or '' by the user. This is in line with
    how path handles partition_expr. Additionally, if output_expr has NULL
    or '' as its value, it is set to '*', which is its default value. Finally,
    the create_view param is also set to its default value True if NULL.
    This commit also contains some formatting changes to the online help.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message