madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] incubator-madlib issue #54: Pivoting: Phase 2
Date Fri, 29 Jul 2016 22:54:40 GMT
Github user iyerr3 commented on the issue:

    https://github.com/apache/incubator-madlib/pull/54
  
    Even for the other two, I suggest keeping the static parts all together with only the
dynamic part created in the loops. That avoids having the `SELECT` clause separated from the
`FROM` by 70 lines. That avoids creating a variable `insert_sql_begin` 50+ lines from where
it's used (and can be replaced by static string `INSERT INTO`).  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message