madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #56: Path: Add support for overlapping pattern...
Date Wed, 27 Jul 2016 20:12:22 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/56#discussion_r72513854
  
    --- Diff: src/ports/postgres/modules/utilities/path.py_in ---
    @@ -40,7 +40,7 @@ m4_changequote(`<!', `!>')
     
     def path(schema_madlib, source_table, output_table, partition_expr,
              order_expr, pattern_expr, symbol_expr, agg_func,
    -         persist_rows=None, **kwargs):
    +         persist_rows=None, overlapping_patterns=None, **kwargs):
    --- End diff --
    
    I had received a similar comment on another module (sessionize), so thought it might be
applicable here. @iyerr3 do you think setting the default to False is something we should
do here too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message