madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mktal <>
Subject [GitHub] incubator-madlib pull request #56: Path: Add support for overlapping pattern...
Date Wed, 27 Jul 2016 19:32:41 GMT
Github user mktal commented on a diff in the pull request:
    --- Diff: src/ports/postgres/modules/utilities/path.py_in ---
    @@ -40,7 +40,7 @@ m4_changequote(`<!', `!>')
     def path(schema_madlib, source_table, output_table, partition_expr,
              order_expr, pattern_expr, symbol_expr, agg_func,
    -         persist_rows=None, **kwargs):
    +         persist_rows=None, overlapping_patterns=None, **kwargs):
    --- End diff --
    I don't see why setting the default value to False is better. As you said, the user can
still explicitly set to NULL and we still need to account for that case.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message