madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #56: Path: Add support for overlapping pattern...
Date Tue, 26 Jul 2016 21:59:05 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/56#discussion_r72345882
  
    --- Diff: src/ports/postgres/modules/utilities/path.py_in ---
    @@ -40,7 +40,7 @@ m4_changequote(`<!', `!>')
     
     def path(schema_madlib, source_table, output_table, partition_expr,
              order_expr, pattern_expr, symbol_expr, agg_func,
    -         persist_rows=None, **kwargs):
    +         persist_rows=None, overlapping_patterns=None, **kwargs):
    --- End diff --
    
    It might be a good idea to set the default value of overlapping_patterns to False instead
of None. 
    From what I gather, it is better to do that in the path.sql_in file where you can pass
False instead of 
    NULL in the overloaded function for the overlapping_patterns param. 
    
    Of course, we will still need to have the "if overlapping_patterns is None:" check below
to handle 
    the case where overlapping_patterns is explicitly set to NULL by the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message