madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From njayaram2 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request #56: Path: Add support for overlapping pattern...
Date Mon, 18 Jul 2016 22:34:05 GMT
Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/56#discussion_r71243432
  
    --- Diff: src/ports/postgres/modules/utilities/path.sql_in ---
    @@ -531,7 +548,7 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.path(
         symbol_expr         VARCHAR,
         pattern_expr        VARCHAR
     ) RETURNS TEXT AS $$
    -    SELECT MADLIB_SCHEMA.path($1, $2, $3, $4, $5, $6, NULL, NULL)
    +    SELECT MADLIB_SCHEMA.path($1, $2, $3, $4, $5, $6, NULL, NULL, NULL)
     $$ LANGUAGE SQL
     m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `MODIFIES SQL DATA', `');
     
    --- End diff --
    
    Having an example with overlapping_patterns = TRUE might be useful in the
    user doc. The same example showing the output with and without overlapping
    patterns might be helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message