Return-Path: 
 <dev-return-352-apmail-madlib-dev-archive=madlib.apache.org@madlib.incubator.apache.org>
X-Original-To: apmail-madlib-dev-archive@minotaur.apache.org
Delivered-To: apmail-madlib-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B4DE3185F8
	for <apmail-madlib-dev-archive@minotaur.apache.org>;
 Sat, 26 Mar 2016 00:17:44 +0000 (UTC)
Received: (qmail 32196 invoked by uid 500); 26 Mar 2016 00:17:44 -0000
Delivered-To: apmail-madlib-dev-archive@madlib.apache.org
Received: (qmail 32150 invoked by uid 500); 26 Mar 2016 00:17:44 -0000
Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@madlib.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@madlib.incubator.apache.org>
List-Post: <mailto:dev@madlib.incubator.apache.org>
List-Id: <dev.madlib.incubator.apache.org>
Reply-To: dev@madlib.incubator.apache.org
Delivered-To: mailing list dev@madlib.incubator.apache.org
Received: (qmail 32139 invoked by uid 99); 26 Mar 2016 00:17:44 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 00:17:44 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org)
 with ESMTP id 093831A057D
	for <dev@madlib.apache.org>; Sat, 26 Mar 2016 00:17:44 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx2-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new,
 port 10024)
	with ESMTP id KtaDseHJo7wU for <dev@madlib.apache.org>;
	Sat, 26 Mar 2016 00:17:42 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP
 id E21B95F3FE
	for <dev@madlib.incubator.apache.org>; Sat, 26 Mar 2016 00:17:41 +0000 (UTC)
Received: (qmail 32126 invoked by uid 99); 26 Mar 2016 00:17:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 00:17:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D6BE8DFC8E; Sat, 26 Mar 2016 00:17:40 +0000 (UTC)
From: iyerr3 <git@git.apache.org>
To: dev@madlib.incubator.apache.org
Reply-To: dev@madlib.incubator.apache.org
References: <git-pr-33-incubator-madlib@git.apache.org>
In-Reply-To: <git-pr-33-incubator-madlib@git.apache.org>
Subject: [GitHub] incubator-madlib pull request: misc doc changes for 1 dot 9
Content-Type: text/plain
Message-Id: <20160326001740.D6BE8DFC8E@git1-us-west.apache.org>
Date: Sat, 26 Mar 2016 00:17:40 +0000 (UTC)

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/33#discussion_r57504661
  
    --- Diff: src/ports/postgres/modules/pca/pca.sql_in ---
    @@ -177,19 +177,29 @@ contain values between 1 and <em>M</em>.</DD>
     
     <DT>components_param</DT>
     <DD>INTEGER or FLOAT.  The parameter to control the number of principal 
    -components to calculate from the input data. If components_param is INTEGER, 
    -it is used for denoting the number of principal components (<em>k</em>) to 
    -compute. If components_param is FLOAT, the algorithm would return enough 
    +components to calculate from the input data. If 'components_param' is INTEGER, 
    +it is used to denote the number of principal components (<em>k</em>) to 
    +compute. If 'components_param' is FLOAT, the algorithm will return enough 
     principal vectors so that the ratio of the sum of the eigenvalues collected 
    -thus far to the sum of all eigenvalues is greater than this parameter.
    -This value has to be either a positive INTEGER or a FLOAT in the range 
    -(0.0,1.0]</DD>
    +thus far to the sum of all eigenvalues is greater than this parameter 
    +(proportion of variance).  The value of 'components_param' must be either 
    +a positive INTEGER or a FLOAT in the range (0.0,1.0]</DD>
    +
    +@note The difference in interpretation between INTEGER and FLOAT was 
    --- End diff --
    
    Replace everywhere: principle -> principal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---