Return-Path: X-Original-To: apmail-madlib-dev-archive@minotaur.apache.org Delivered-To: apmail-madlib-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1FE0118583 for ; Sat, 26 Mar 2016 00:02:31 +0000 (UTC) Received: (qmail 15835 invoked by uid 500); 26 Mar 2016 00:02:31 -0000 Delivered-To: apmail-madlib-dev-archive@madlib.apache.org Received: (qmail 15793 invoked by uid 500); 26 Mar 2016 00:02:31 -0000 Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.incubator.apache.org Delivered-To: mailing list dev@madlib.incubator.apache.org Received: (qmail 15782 invoked by uid 99); 26 Mar 2016 00:02:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 00:02:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 69402180553 for ; Sat, 26 Mar 2016 00:02:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id orwx3yeE6vkZ for ; Sat, 26 Mar 2016 00:02:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 3AF695F2F2 for ; Sat, 26 Mar 2016 00:02:28 +0000 (UTC) Received: (qmail 15778 invoked by uid 99); 26 Mar 2016 00:02:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Mar 2016 00:02:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5FCD1DFC8E; Sat, 26 Mar 2016 00:02:28 +0000 (UTC) From: iyerr3 To: dev@madlib.incubator.apache.org Reply-To: dev@madlib.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-madlib pull request: misc doc changes for 1 dot 9 Content-Type: text/plain Message-Id: <20160326000228.5FCD1DFC8E@git1-us-west.apache.org> Date: Sat, 26 Mar 2016 00:02:28 +0000 (UTC) Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/33#discussion_r57503961 --- Diff: src/ports/postgres/modules/elastic_net/elastic_net.sql_in --- @@ -130,7 +130,13 @@ the dependent variable expression to the excluded string.

BOOLEAN, default: TRUE. Whether to normalize the data. Setting this to TRUE usually yields better results and faster convergence.

grouping_col (optional)

TEXT, default: NULL. Not currently implemented. Any non-NULL value is ignored. An expression list used to group the input dataset into discrete groups, running one regression per group. Similar to the SQL GROUP BY clause. When this value is NULL, no grouping is used and a single result model is generated.

TEXT, default: NULL. + +@note Not currently implemented. Any non-NULL value is ignored. +Grouping support will be added in a future release. +An expression list used to group the input dataset into discrete groups, --- End diff -- Maybe we shouldn't say anything about the expression list, since grouping isn't implemented yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---