Return-Path: X-Original-To: apmail-madlib-dev-archive@minotaur.apache.org Delivered-To: apmail-madlib-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6ACC185EC for ; Fri, 11 Mar 2016 22:12:18 +0000 (UTC) Received: (qmail 19194 invoked by uid 500); 11 Mar 2016 22:12:18 -0000 Delivered-To: apmail-madlib-dev-archive@madlib.apache.org Received: (qmail 19153 invoked by uid 500); 11 Mar 2016 22:12:18 -0000 Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.incubator.apache.org Delivered-To: mailing list dev@madlib.incubator.apache.org Received: (qmail 19142 invoked by uid 99); 11 Mar 2016 22:12:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Mar 2016 22:12:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F12D7C0095 for ; Fri, 11 Mar 2016 22:12:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id H0z59RF6z-CO for ; Fri, 11 Mar 2016 22:12:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5338C5FAC4 for ; Fri, 11 Mar 2016 22:12:16 +0000 (UTC) Received: (qmail 19134 invoked by uid 99); 11 Mar 2016 22:12:15 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Mar 2016 22:12:15 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4B2D5DFC11; Fri, 11 Mar 2016 22:12:15 +0000 (UTC) From: iyerr3 To: dev@madlib.incubator.apache.org Reply-To: dev@madlib.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-madlib pull request: SVM: Using temp table when generati... Content-Type: text/plain Message-Id: <20160311221215.4B2D5DFC11@git1-us-west.apache.org> Date: Fri, 11 Mar 2016 22:12:15 +0000 (UTC) Github user iyerr3 commented on the pull request: https://github.com/apache/incubator-madlib/pull/28#issuecomment-195573062 Judging by how 'table_type' is used, I would expect 'TEMP' is the only useful/valid value. We should change that parameter to a boolean and add the 'TEMP' text in the called function. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---