madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iyerr3 <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request: misc doc changes for 1 dot 9
Date Sat, 26 Mar 2016 00:02:28 GMT
Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/33#discussion_r57503961
  
    --- Diff: src/ports/postgres/modules/elastic_net/elastic_net.sql_in ---
    @@ -130,7 +130,13 @@ the dependent variable expression to the <em>excluded</em>
string.</DD>
     <DD>BOOLEAN, default: TRUE. Whether to normalize the data. Setting this to TRUE
usually yields better results and faster convergence.</DD>
     
     <DT>grouping_col (optional)</DT>
    -<DD>TEXT, default: NULL. <em>Not currently implemented. Any non-NULL value
is ignored.</em> An expression list used to group the input dataset into discrete groups,
running one regression per group. Similar to the SQL <tt>GROUP BY</tt> clause.
When this value is NULL, no grouping is used and a single result model is generated.</DD>
    +<DD>TEXT, default: NULL. 
    +
    +@note <em>Not currently implemented. Any non-NULL value is ignored.
    +Grouping support will be added in a future release. </em>
    +An expression list used to group the input dataset into discrete groups, 
    --- End diff --
    
    Maybe we shouldn't say anything about the expression list, since grouping isn't implemented
yet. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message