madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mktal <...@git.apache.org>
Subject [GitHub] incubator-madlib pull request: Path: Return results for each match
Date Thu, 24 Mar 2016 18:57:17 GMT
Github user mktal commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/29#discussion_r57369772
  
    --- Diff: src/ports/postgres/modules/utilities/path.py_in ---
    @@ -108,8 +107,11 @@ def path(schema_madlib, source_table, output_table, partition_expr,
                                 *,
                                 nextval('{seq_gen}') AS {id_col_name},
    --- End diff --
    
    why not simply `row_number() over ()`? (no need to create and drop the sequence)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message