Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@madlib.incubator.apache.org
From: iyerr3 <git@git.apache.org>
To: dev@madlib.incubator.apache.org
Reply-To: dev@madlib.incubator.apache.org
References: <git-pr-4-incubator-madlib@git.apache.org>
In-Reply-To: <git-pr-4-incubator-madlib@git.apache.org>
Subject: [GitHub] incubator-madlib pull request: SVM: Add cross validation
 support a...
Content-Type: text/plain
Message-Id: <20151125211828.1ED01DFC64@git1-us-west.apache.org>
Date: Wed, 25 Nov 2015 21:18:28 +0000 (UTC)

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/4#discussion_r45920065
  
    --- Diff: src/ports/postgres/modules/svm/svm.py_in ---
    @@ -389,11 +521,20 @@ def _process_epsilon(is_svc, args):
         as_rel_source = '_src'
     
         epsilon = args['epsilon']
    -    if is_svc or not grouping_col or not eps_table:
    +    # c code does SVR when epsilon is non-zero
    +    if is_svc:
    +        epsilon = 0.0
    +        select_epsilon = '{epsilon}'.format(epsilon=epsilon)
    +    elif not grouping_col or not eps_table:
             if eps_table:
    -            plpy.warning('SVM: ignoring the input epsilon table!')
    -        select_epsilon = str(epsilon)
    +            plpy.warning('SVM warning: no grouping and '
    +                         ' ignore the input epsilon table!')
    +        # c code does SVC if epsilon is zero
    +        if epsilon == 0: epsilon = 0.00001
    --- End diff --
    
    Also please look at the setting epsilon to low value part. I had added the `is_svc` boolean during the regression commit to avoid this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---