Return-Path: 
 <dev-return-15-apmail-madlib-dev-archive=madlib.apache.org@madlib.incubator.apache.org>
X-Original-To: apmail-madlib-dev-archive@minotaur.apache.org
Delivered-To: apmail-madlib-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C384C18CD1
	for <apmail-madlib-dev-archive@minotaur.apache.org>;
 Thu,  5 Nov 2015 21:31:12 +0000 (UTC)
Received: (qmail 61401 invoked by uid 500); 5 Nov 2015 21:31:12 -0000
Delivered-To: apmail-madlib-dev-archive@madlib.apache.org
Received: (qmail 61371 invoked by uid 500); 5 Nov 2015 21:31:12 -0000
Mailing-List: contact dev-help@madlib.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@madlib.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@madlib.incubator.apache.org>
List-Post: <mailto:dev@madlib.incubator.apache.org>
List-Id: <dev.madlib.incubator.apache.org>
Reply-To: dev@madlib.incubator.apache.org
Delivered-To: mailing list dev@madlib.incubator.apache.org
Received: (qmail 61360 invoked by uid 99); 5 Nov 2015 21:31:12 -0000
Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2015 21:31:12 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org)
 with ESMTP id 0C7511A41D5
	for <dev@madlib.apache.org>; Thu,  5 Nov 2015 21:31:12 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new,
 port 10024)
	with ESMTP id IBdTaufft61Z for <dev@madlib.apache.org>;
	Thu,  5 Nov 2015 21:31:11 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id ABC3E20ED5
	for <dev@madlib.incubator.apache.org>; Thu,  5 Nov 2015 21:31:10 +0000 (UTC)
Received: (qmail 61222 invoked by uid 99); 5 Nov 2015 21:31:09 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2015 21:31:09 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id A8AF8E3938; Thu,  5 Nov 2015 21:31:09 +0000 (UTC)
From: iyerr3 <git@git.apache.org>
To: dev@madlib.incubator.apache.org
Reply-To: dev@madlib.incubator.apache.org
References: <git-pr-1-incubator-madlib@git.apache.org>
In-Reply-To: <git-pr-1-incubator-madlib@git.apache.org>
Subject: [GitHub] incubator-madlib pull request: Feature/svm grouping
Content-Type: text/plain
Message-Id: <20151105213109.A8AF8E3938@git1-us-west.apache.org>
Date: Thu,  5 Nov 2015 21:31:09 +0000 (UTC)

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/1#discussion_r44072022
  
    --- Diff: src/modules/convex/linear_svm_igd.cpp ---
    @@ -95,19 +90,16 @@ linear_svm_igd_transition::run(AnyType &args) {
         using madlib::dbal::eigen_integration::MappedColumnVector;
         GLMTuple tuple;
         tuple.indVar.rebind(args[1].getAs<MappedColumnVector>().memoryHandle(),
    -            state.task.dimension);
    -    tuple.depVar = args[2].getAs<bool>() ? 1. : -1.;
    +                        state.task.dimension);
    +    tuple.depVar = args[2].getAs<double>();
     
         // Now do the transition step
         // apply IGD with regularization
    -    if (isL2) {
    -        L2<GLMModel>::scaling(state.algo.incrModel, lambda, nTuples, state.task.stepsize);
    -        LinearSVMIGDAlgorithm::transition(state, tuple);
    -    } else {
    -        LinearSVMIGDAlgorithm::transition(state, tuple);
    -        L1<GLMModel>::clipping(state.algo.incrModel, lambda, nTuples, state.task.stepsize);
    -    }
    -    // objective function and its gradient
    +    L2<GLMModel>::scaling(state.task.model, state.algo.incrModel, state.task.stepsize);
    --- End diff --
    
    Why not check the isL2 variable and only perform the necessary computation? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---