Mailing-List: contact pylucene-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pylucene-dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Date: Tue, 5 Oct 2010 11:50:29 -0700 (PDT)
From: Andi Vajda <vajda@apache.org>
Reply-To: Andi Vajda <vajda@apache.org>
To: pylucene-dev@lucene.apache.org
cc: janssen@parc.com
Subject: Re: Can't build 3.0.2 with gcc 4.5 and mingw/msys on Windows XP
In-Reply-To: <55312.1286304230@parc.com>
Message-ID: <alpine.OSX.2.01.1010051148090.46381@yuzu.local>
References: <AANLkTi=Vy3vzuVjp-cJpDQwWZDA5DrVUSvFFFaXyeJda@mail.gmail.com>
 <alpine.OSX.2.01.1010011124390.69082@yuzu.local>
 <AANLkTimo04jZ0i4gJntiKHkJEJM6aH663K1R7Rzu7pfD@mail.gmail.com>
 <55312.1286304230@parc.com>
User-Agent: Alpine 2.01 (OSX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed


On Tue, 5 Oct 2010, Bill Janssen wrote:

> I'm trying to build JCC 2.6 (from the PyLucene 3.0.2 source bundle) with
> GCC 4.5 on Windows XP using MinGW/msys.
>
> creating build\temp.win32-2.6\Release\jcc\sources
> c:\MinGW\bin\gcc.exe -mno-cygwin -mdll -O -Wall -D_jcc_lib -DJCC_VER="2.6" "-IC:\Program Files\Java\jdk1.6.0_21\include" "-IC:\Program Files\Java\jdk1.6.0_21\include\win32" -I_jcc -Ijcc/sources -Ic:\Python26\include -Ic:\Python26\PC -c jcc/sources/jcc.cpp -o build\temp.win32-2.6\Release\jcc\sources\jcc.o -DPYTHON -fno-strict-aliasing -Wno-write-strings
> jcc/sources/jcc.cpp: In function 'PyObject* initJCC(PyObject*)':
> jcc/sources/jcc.cpp:337:48: error: cannot convert 'double' to 'const char*' for argument '1' to 'PyObject* PyString_FromString(const char*)'
> error: command 'gcc' failed with exit status 1
>
> I believe the #ifdef a few lines above needs to change from
>
> #ifdef _MSC_VER
>
> to
>
> #if defined(_MSC_VER) || defined(__WIN32)
>
> to match the similar #ifdefs elsewhere in the code.
>
> JCC_VER is a double on Windows but a string elsewhere?  Odd.

Probably because it lost "" somewhere like where the compiler 
was invoked from. -Dfoo=1.2 instead of -Dfoo="1.2".
The verstring macro in the conditional you found fixes this.

As you suggest, it should have the extra check for __WIN32 like elsewhere.

Thanks !

Andi..