From reviews-return-1816-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org  Tue Sep  3 13:20:08 2019
Return-Path: <reviews-return-1816-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 4B908180674
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  3 Sep 2019 15:20:08 +0200 (CEST)
Received: (qmail 66258 invoked by uid 500); 3 Sep 2019 15:16:01 -0000
Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@livy.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@livy.incubator.apache.org>
List-Post: <mailto:reviews@livy.incubator.apache.org>
List-Id: <reviews.livy.incubator.apache.org>
Reply-To: reviews@livy.incubator.apache.org
Delivered-To: mailing list reviews@livy.incubator.apache.org
Received: (qmail 66190 invoked by uid 99); 3 Sep 2019 15:16:01 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Sep 2019 15:16:01 +0000
From: GitBox <git@apache.org>
To: reviews@livy.apache.org
Subject: [GitHub] [incubator-livy] captainzmc commented on a change in pull request
 #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider
 implementation in ThriftServer
Message-ID: <156751680614.3373.13782361364116595611.gitbox@gitbox.apache.org>
Date: Tue, 03 Sep 2019 13:20:06 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r320266942
 
 

 ##########
 File path: thriftserver/server/pom.xml
 ##########
 @@ -56,6 +56,21 @@
         </exclusion>
       </exclusions>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hive</groupId>
+      <artifactId>hive-common</artifactId>
+      <version>${hive.version}</version>
+      <exclusions>
 
 Review comment:
   This will lead to the following jars in thriftserver, which will cause livy's logs to fail to display. We need to exclusion them.
   log4j-1.2-api-2.10.0.jar
   log4j-api-2.10.0.jar
   log4j-core-2.10.0.jar
   log4j-slf4j-impl-2.10.0.jar
   log4j-web-2.10.0.jar

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services