From reviews-return-1803-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org Mon Sep 2 14:56:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE490180658 for ; Mon, 2 Sep 2019 16:56:47 +0200 (CEST) Received: (qmail 87273 invoked by uid 500); 2 Sep 2019 16:11:16 -0000 Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@livy.incubator.apache.org Delivered-To: mailing list reviews@livy.incubator.apache.org Received: (qmail 87262 invoked by uid 99); 2 Sep 2019 16:11:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 16:11:16 +0000 From: GitBox To: reviews@livy.apache.org Subject: [GitHub] [incubator-livy] codecov-io edited a comment on issue #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished Message-ID: <156743620732.17000.14798251504044302750.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 14:56:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222#issuecomment-527123056 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=h1) Report > Merging [#222](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/d0d8028657c7314ad031f51c0a564a8786213187?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `80%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-livy/pull/222/graphs/tree.svg?width=650&token=0MkVbiUFwE&height=150&src=pr)](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #222 +/- ## ============================================ - Coverage 68.34% 68.31% -0.04% - Complexity 919 922 +3 ============================================ Files 100 100 Lines 5715 5718 +3 Branches 867 868 +1 ============================================ Hits 3906 3906 - Misses 1242 1245 +3 Partials 567 567 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...cala/org/apache/livy/sessions/SessionManager.scala](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9TZXNzaW9uTWFuYWdlci5zY2FsYQ==) | `82.35% <80%> (+0.53%)` | `30 <4> (+3)` | :arrow_up: | | [...cala/org/apache/livy/repl/ProcessInterpreter.scala](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9Qcm9jZXNzSW50ZXJwcmV0ZXIuc2NhbGE=) | `57.14% <0%> (-2.39%)` | `6% <0%> (ø)` | | | [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `73.91% <0%> (-1.25%)` | `20% <0%> (ø)` | | | [...scala/org/apache/livy/repl/SparkRInterpreter.scala](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9TcGFya1JJbnRlcnByZXRlci5zY2FsYQ==) | `60.11% <0%> (-0.58%)` | `14% <0%> (ø)` | | | [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh) | `58.33% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: | | [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/222/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=footer). Last update [d0d8028...794353a](https://codecov.io/gh/apache/incubator-livy/pull/222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services