From reviews-return-1791-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org Mon Sep 2 09:32:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2E638180658 for ; Mon, 2 Sep 2019 11:32:30 +0200 (CEST) Received: (qmail 29400 invoked by uid 500); 2 Sep 2019 10:04:41 -0000 Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@livy.incubator.apache.org Delivered-To: mailing list reviews@livy.incubator.apache.org Received: (qmail 29389 invoked by uid 99); 2 Sep 2019 10:04:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 10:04:41 +0000 From: GitBox To: reviews@livy.apache.org Subject: [GitHub] [incubator-livy] o-shevchenko commented on a change in pull request #189: [LIVY-616] Livy Server discovery Message-ID: <156741674951.9254.13911026249670185860.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 09:32:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit o-shevchenko commented on a change in pull request #189: [LIVY-616] Livy Server discovery URL: https://github.com/apache/incubator-livy/pull/189#discussion_r319879135 ########## File path: server/src/main/scala/org/apache/livy/server/discovery/LivyDiscoveryManager.scala ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.livy.server.discovery + +import java.net.URI + +import org.apache.curator.framework.CuratorFramework + +import org.apache.livy.LivyConf + +/** + * Livy Server Discovery manager. + * Stores information about Livy Server location in ZooKeeper. + * The address will be stored in + * "/{@code LIVY_ZOOKEEPER_NAMESPACE}/{@code LIVY_SERVER_ZOOKEEPER_NAMESPACE}" znode + * By default, the full path to znode is /livy/server.uri. + * Need to set {@code livy.zookeeper.url} to be able to get information from ZooKeeper. + * + * @param livyConf - Livy configurations + * @param mockCuratorClient - used for testing + */ +class LivyDiscoveryManager(val livyConf: LivyConf, Review comment: Also, I have tried to make all configurations more generic and configurable on the top level to use it everywhere. As far as I see, for now, we have a couple of PRs with different ZK logic which can't be reused a lot and I see too specific confs like "livy.server.thrift.zookeeper.quorum" instead of simple common "livy.zookeeper.url" which can be reused. In this PR I want to not only add LivyServer discovery but also create init structure for subsequent work with ZooKeeper. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services