livy-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-livy] o-shevchenko commented on a change in pull request #189: [LIVY-616] Livy Server discovery
Date Mon, 02 Sep 2019 09:39:20 GMT
o-shevchenko commented on a change in pull request #189: [LIVY-616] Livy Server discovery

 File path: server/src/main/scala/org/apache/livy/server/discovery/LivyDiscoveryManager.scala
 @@ -0,0 +1,65 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.livy.server.discovery
+import org.apache.curator.framework.CuratorFramework
+import org.apache.livy.LivyConf
+  * Livy Server Discovery manager.
+  * Stores information about Livy Server location in ZooKeeper.
+  * The address will be stored in
+  * By default, the full path to znode is /livy/server.uri.
+  * Need to set {@code livy.zookeeper.url} to be able to get information from ZooKeeper.
+  *
+  * @param livyConf - Livy configurations
+  * @param mockCuratorClient - used for testing
+  */
+class LivyDiscoveryManager(val livyConf: LivyConf,
 Review comment:
   Also, I have tried to make all configurations more generic and configurable on the top
level to use it everywhere. As far as I see, for now, we have a couple of PRs with different
ZK logic which can't be reused a lot and I see too specific confs like `livy.server.thrift.zookeeper.quorum`
instead of simple common `livy.zookeeper.url` which can be reused. In this PR I want to not
only add LivyServer discovery but also create init structure for subsequent work with ZooKeeper.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message