From reviews-return-127-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org  Fri Nov 30 19:25:15 2018
Return-Path: <reviews-return-127-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 9835B180671
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 30 Nov 2018 19:25:14 +0100 (CET)
Received: (qmail 88919 invoked by uid 500); 30 Nov 2018 18:25:13 -0000
Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@livy.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@livy.incubator.apache.org>
List-Post: <mailto:reviews@livy.incubator.apache.org>
List-Id: <reviews.livy.incubator.apache.org>
Reply-To: reviews@livy.incubator.apache.org
Delivered-To: mailing list reviews@livy.incubator.apache.org
Received: (qmail 88908 invoked by uid 99); 30 Nov 2018 18:25:13 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2018 18:25:13 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 0693CDFAB2; Fri, 30 Nov 2018 18:25:13 +0000 (UTC)
From: vanzin <git@git.apache.org>
To: reviews@livy.apache.org
Reply-To: reviews@livy.apache.org
References: <git-pr-128-incubator-livy@git.apache.org>
In-Reply-To: <git-pr-128-incubator-livy@git.apache.org>
Subject: [GitHub] incubator-livy pull request #128: [LIVY-533] Use setJobGroup/cancelJobGroup ...
Content-Type: text/plain
Message-Id: <20181130182513.0693CDFAB2@git1-us-west.apache.org>
Date: Fri, 30 Nov 2018 18:25:13 +0000 (UTC)

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/128#discussion_r237956271
  
    --- Diff: rsc/src/main/java/org/apache/livy/rsc/driver/JobWrapper.java ---
    @@ -38,21 +34,31 @@
       public final String jobId;
     
       private final RSCDriver driver;
    +
       private final Job<T> job;
    -  private final AtomicInteger completed;
    +
    +  private boolean isCancelled = false;
     
       private Future<?> future;
     
       public JobWrapper(RSCDriver driver, String jobId, Job<T> job) {
         this.driver = driver;
         this.jobId = jobId;
         this.job = job;
    -    this.completed = new AtomicInteger();
       }
     
       @Override
       public Void call() throws Exception {
         try {
    +      // this is synchronized to avoid races with cancel()
    +      synchronized (this) {
    +        if (isCancelled) {
    +          throw new Exception("Job isCancelled");
    --- End diff --
    
    Throw `CancellationException` instead.


---