From reviews-return-119-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org  Thu Nov 29 11:19:23 2018
Return-Path: <reviews-return-119-archive-asf-public=cust-asf.ponee.io@livy.incubator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id C381D18066C
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 29 Nov 2018 11:19:22 +0100 (CET)
Received: (qmail 78675 invoked by uid 500); 29 Nov 2018 10:19:21 -0000
Mailing-List: contact reviews-help@livy.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@livy.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@livy.incubator.apache.org>
List-Post: <mailto:reviews@livy.incubator.apache.org>
List-Id: <reviews.livy.incubator.apache.org>
Reply-To: reviews@livy.incubator.apache.org
Delivered-To: mailing list reviews@livy.incubator.apache.org
Received: (qmail 78655 invoked by uid 99); 29 Nov 2018 10:19:21 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Nov 2018 10:19:21 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 35234DFDA7; Thu, 29 Nov 2018 10:19:20 +0000 (UTC)
From: mgaido91 <git@git.apache.org>
To: reviews@livy.apache.org
Reply-To: reviews@livy.apache.org
References: <git-pr-117-incubator-livy@git.apache.org>
In-Reply-To: <git-pr-117-incubator-livy@git.apache.org>
Subject: [GitHub] incubator-livy issue #117: [LIVY-502] Remove dependency on hive-exec
Content-Type: text/plain
Message-Id: <20181129101921.35234DFDA7@git1-us-west.apache.org>
Date: Thu, 29 Nov 2018 10:19:20 +0000 (UTC)

Github user mgaido91 commented on the issue:

    https://github.com/apache/incubator-livy/pull/117
  
    Thanks for the review @vanzin! I addressed your comments.
    
    > I still think there's stuff to clean up here
    
    Not sure what you mean here exactly, but I think that after this patch we may start working with the Hive community in order to make some things easier to be re-used. Eg. we cannot reuse all the auth classes because they depend on the `HiveConf` we may propose to the Hive community to have them accepting in the constructor the parameters they need instead of the `HiveConf`, so we can reuse them. This may help reducing significantly the code size here.


---